OpenConceptLab/ocl_issues#1564 | removed name from importers

OpenConceptLab · Apr 25, 2023 · d5b0bce · d5b0bce
1 parent e54e072
commit d5b0bce
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/core/common/management/commands/import_lookup_values.py b/core/common/management/commands/import_lookup_values.py
@@ -122,7 +122,6 @@ def create_concepts(source, file, user):
             mnemonic = data.pop('id', None)
             if not Concept.objects.filter(parent=source, mnemonic=mnemonic, is_latest_version=True).exists():
                 data['mnemonic'] = mnemonic
-                data['name'] = mnemonic
                 data['parent'] = source
                 Concept.persist_new(data, user)
                 if not created:

diff --git a/core/importers/models.py b/core/importers/models.py
@@ -402,7 +402,7 @@ def parse(self):
         ).first()
         super().parse()
         self.data['parent'] = source
-        self.data['name'] = self.data['mnemonic'] = str(self.data.pop('id', ''))
+        self.data['mnemonic'] = str(self.data.pop('id', ''))
         if not is_url_encoded_string(self.data['mnemonic']):
             self.data['mnemonic'] = encode_string(self.data['mnemonic'])
 

diff --git a/core/integration_tests/tests_concepts.py b/core/integration_tests/tests_concepts.py
@@ -93,7 +93,6 @@ def test_post_201(self):
                 'versions_url',
                 'version',
                 'extras',
-                'name',
                 'type',
                 'update_comment',
                 'version_url',
@@ -130,7 +129,6 @@ def test_post_201(self):
         self.assertEqual(response.data['versions_url'], concept.uri + 'versions/')
         self.assertEqual(response.data['version'], str(concept.id))
         self.assertEqual(response.data['extras'], {'foo': 'bar'})
-        self.assertEqual(response.data['name'], 'c1')
         self.assertEqual(response.data['type'], 'Concept')
         self.assertEqual(response.data['version_url'], latest_version.uri)
 
@@ -194,7 +192,6 @@ def test_put_200(self):
                     'versions_url',
                     'version',
                     'extras',
-                    'name',
                     'type',
                     'update_comment',
                     'version_url',
@@ -270,7 +267,6 @@ def test_put_200_openmrs_schema(self):  # pylint: disable=too-many-statements
                     'versions_url',
                     'version',
                     'extras',
-                    'name',
                     'type',
                     'update_comment',
                     'version_url',
@@ -712,7 +708,7 @@ def test_get_200_with_response_modes(self):
             sorted(response.data[0].keys()),
             sorted(['uuid', 'id', 'external_id', 'concept_class', 'datatype', 'url', 'retired', 'source',
                     'owner', 'owner_type', 'owner_url', 'display_name', 'display_locale', 'names', 'descriptions',
-                    'created_on', 'updated_on', 'versions_url', 'version', 'extras', 'name', 'type',
+                    'created_on', 'updated_on', 'versions_url', 'version', 'extras', 'type',
                     'update_comment', 'version_url', 'updated_by', 'created_by',
                     'public_can_view', 'versioned_object_id', 'checksums'])
         )