Fix IllegalArgumentException caused by LaunchClassLoader's modification to CodeSource. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to CodeSource.
Barteks2x
reviewed
Mar 3, 2020
There was a problem hiding this comment.
I haven't looked at that project in quite a while, but despite any errors it showed (I never looked at them too closely after initial development, so don't remember if they are the same), it always worked fine for me, as long as I didn't try to run it in it's own dev environment.
So what issue exactly does this try to fix?
| classLoaderExceptions.removeIf(t -> t.startsWith("optifine")); | ||
| Set<String> transformerExceptions = | ||
| UtilsLW.getFieldValue(LaunchClassLoader.class, Launch.classLoader, "transformerExceptions"); | ||
| transformerExceptions.removeIf(t -> t.startsWith("optifine")); |
|
I re-read some of the code and iirc, the way I got around the issue was by reflectively setting the fields that the crashing code was supposed to set. This works because optifine catches and logs the exception, but transformer instance is still created. With this, it should be unnecessary to reflectively set these fields when creating wrapped instance of OF class transformer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Barteks2x I used this mod in dev environment by it didn't work well for me:
LaunchClassLoaderwill modify CodeSources of all classes if they are not intransformerExceptions.In other words, it will return different results of
this.getClass().getProtectionDomain().getCodeSource().getLocation().toURI()for different class loaders.For
sun.misc.Launcher$AppClassLoader, it will returnBut for
net.minecraft.launchwrapper.LaunchClassLoader, it will retrunSo it is neccessary to add
optifine.into transfomer excxceptions.