Add C++17 build to CI (#231)

* Add C++17 build to CI

closes #228
- Also fixes a sq code-smell.
- fixes a unit tests that was invalid (missing memset of a datastructure)

.github/verify.py

@@ -439,7 +439,7 @@ def _cmake_configure(args: argparse.Namespace, cmake_args: typing.List[str], cma
         cmake_configure_args.append("-DNUNAVUT_VERIFICATION_SER_FP_DISABLE:BOOL=ON")
 
     if args.enable_ovr_var_array:
-        cmake_configure_args.append("-NUNAVUT_VERIFICATION_OVR_VAR_ARRAY_ENABLE:BOOL=ON")
+        cmake_configure_args.append("-DNUNAVUT_VERIFICATION_OVR_VAR_ARRAY_ENABLE:BOOL=ON")
 
     if args.verbose > 0:
         cmake_configure_args.append("-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON")
@@ -510,6 +510,9 @@ def _cmake_test(args: argparse.Namespace, cmake_args: typing.List[str], cmake_di
 def _create_build_dir_name(args: argparse.Namespace) -> str:
     name = "build_{}".format(args.language)
 
+    if args.language_standard is not None:
+        name += "_{}".format(args.language_standard)
+
     name += "_{}".format(args.toolchain_family)
 
     if args.platform is not None:

.github/workflows/test_and_release.yml

@@ -141,7 +141,7 @@ jobs:
                           --build-type ${{ matrix.build_type }} \
                           ${{ matrix.flag }}
 
-  language-verification-cpp:
+  language-verification-cpp-14:
     runs-on: ubuntu-latest
     needs: test
     container: uavcan/c_cpp:ubuntu-20.04
@@ -166,12 +166,41 @@ jobs:
         .github/verify.py --override .github/verify_global.ini \
                           --override .github/verify_cpp_${{ matrix.compiler }}_${{ matrix.architecture }}.ini \
                           --build-type ${{ matrix.build_type }} \
+                          --language-standard c++14 \
+                          ${{ matrix.flag }}
+
+  language-verification-cpp-17:
+    runs-on: ubuntu-latest
+    needs: test
+    container: uavcan/c_cpp:ubuntu-20.04
+    strategy:
+      matrix:
+        build_type: [Debug, Release, MinSizeRel]
+        architecture: [native32, native64]
+        compiler: [gcc, clang]
+        flag: [--none, --enable-ovr-var-array, --disable-asserts]
+        exclude:
+          - build_type: Debug
+            flag: --disable-asserts
+          - build_type: Release
+            flag: --disable-asserts
+
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        submodules: true
+    - name: verify
+      run: |
+        .github/verify.py --override .github/verify_global.ini \
+                          --override .github/verify_cpp_${{ matrix.compiler }}_${{ matrix.architecture }}.ini \
+                          --build-type ${{ matrix.build_type }} \
+                          --language-standard c++17 \
                           ${{ matrix.flag }}
 
   release:
     if: ${{ github.ref == 'refs/heads/main' && github.event_name != 'pull_request' && github.repository == 'UAVCAN/nunavut' }}
     runs-on: ubuntu-latest
-    needs: [compat-test-python3, language-verification-cpp, language-verification-c, sonar]
+    needs: [compat-test-python3, language-verification-cpp-14, language-verification-cpp-17, language-verification-c, sonar]
     steps:
     - uses: actions/setup-python@v2
       with:

.vscode/c_cpp_properties.json

@@ -18,6 +18,7 @@
                 "/System/Library/Frameworks",
                 "/Library/Frameworks"
             ],
+            "defines": ["NUNAVUT_SUPPORT_LANGUAGE_OPTION_ENABLE_OVERRIDE_VARIABLE_ARRAY_CAPACITY=1"],
             "compileCommands": "${workspaceFolder}/.vscode/compile_commands.json",
             "configurationProvider": "ms-vscode.cmake-tools",
             "cStandard": "c11",

.vscode/cmake-kits.json

@@ -51,6 +51,25 @@
             "NUNAVUT_VERIFICATION_TARGET_PLATFORM": "native32"
         }
     },
+    {
+        "name": "native64-gcc-c-nocov",
+        "toolchainFile": "${workspaceFolder}/verification/cmake/toolchains/gcc-native.cmake",
+        "cmakeSettings": {
+            "NUNAVUT_VERIFICATION_LANG": "c",
+            "NUNAVUT_VERIFICATION_TARGET_PLATFORM": "native64",
+            "NUNAVUT_FLAGSET": "${workspaceFolder}/verification/cmake/compiler_flag_sets/native.cmake"
+        }
+    },
+    {
+        "name": "native64-clang-c-nocov",
+        "toolchainFile": "${workspaceFolder}/verification/cmake/toolchains/clang-native.cmake",
+        "cmakeSettings": {
+            "NUNAVUT_VERIFICATION_LANG": "c",
+            "NUNAVUT_VERIFICATION_TARGET_PLATFORM": "native64",
+            "NUNAVUT_FLAGSET": "${workspaceFolder}/verification/cmake/compiler_flag_sets/native.cmake",
+            "NUNAVUT_VERIFICATION_OVR_VAR_ARRAY_ENABLE": "ON"
+        }
+    },
     {
         "name": "native-gcc-cpp-nocov",
         "toolchainFile": "${workspaceFolder}/verification/cmake/toolchains/gcc-native.cmake",

.vscode/settings.json

@@ -46,6 +46,9 @@
     "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
     "C_Cpp.configurationWarnings": "Disabled",
     "files.associations": {
+        "*.py.template": "python",
+        "*.cc": "c++",
+        "*.hpp": "c++",
         "__bit_reference": "cpp",
         "__config": "cpp",
         "__debug": "cpp",

README.rst

@@ -42,7 +42,7 @@ The following languages are currently on the roadmap:
 
 - **Python** (already supported in `PyUAVCAN`_, pending
   `transplantation into Nunavut <https://github.com/UAVCAN/pyuavcan/issues/110>`_)
-- **C++11** (generates header-only libraries; `work-in-progress <https://github.com/UAVCAN/nunavut/issues/91>`_)
+- **C++ 14 and newer** (generates header-only libraries; `work-in-progress <https://github.com/UAVCAN/nunavut/issues/91>`_)
 
 Nunavut is named after the `Canadian territory`_. We chose the name because it
 is a beautiful word to say and read. Also, the name fits with a theme of "places

src/nunavut/lang/cpp/__init__.py

@@ -31,7 +31,7 @@ class Language(BaseLanguage):
     Concrete, C++-specific :class:`nunavut.lang.Language` object.
     """
 
-    CPP_STD_EXTRACT_NUMBER_PATTERN = re.compile(r"(?:gnu|c)\+\+(\d(?:\d|\w))")
+    CPP_STD_EXTRACT_NUMBER_PATTERN = re.compile(r"(?:gnu|c)\+\+(\d(?:\w))")
 
     @staticmethod
     def _handle_stropping_or_encoding_failure(

verification/c/suite/test_override_variable_array_capacity.c

@@ -2,6 +2,8 @@
 // This software is distributed under the terms of the MIT License.
 
 
+#include <nunavut/support/serialization.h>
+
 #if NUNAVUT_SUPPORT_LANGUAGE_OPTION_ENABLE_OVERRIDE_VARIABLE_ARRAY_CAPACITY == 1
 #  define OVERRIDE_SIZE 2
 #  define regulated_basics_PrimitiveArrayVariable_0_1_a_u64_ARRAY_CAPACITY_ OVERRIDE_SIZE
@@ -17,11 +19,14 @@
 static void testPrimitiveArrayVariableOverride(void)
 {
     regulated_basics_PrimitiveArrayVariable_0_1 ref;
+    memset(&ref, 0, sizeof(ref));
     uint8_t buf[regulated_basics_PrimitiveArrayVariable_0_1_SERIALIZATION_BUFFER_SIZE_BYTES_ - 1];
 
 #if NUNAVUT_SUPPORT_LANGUAGE_OPTION_ENABLE_OVERRIDE_VARIABLE_ARRAY_CAPACITY == 1
-    TEST_ASSERT_EQUAL(sizeof(ref.a_u64.elements[0]) * OVERRIDE_SIZE, sizeof(ref.a_u64.elements));
-    TEST_ASSERT_EQUAL(sizeof(ref.n_f64.elements[0]) * OVERRIDE_SIZE, sizeof(ref.n_f64.elements));
+    TEST_ASSERT_EQUAL(OVERRIDE_SIZE, regulated_basics_PrimitiveArrayVariable_0_1_a_u64_ARRAY_CAPACITY_);
+    TEST_ASSERT_EQUAL(OVERRIDE_SIZE, sizeof(ref.a_u64.elements) / sizeof(ref.a_u64.elements[0]));
+    TEST_ASSERT_EQUAL(OVERRIDE_SIZE, regulated_basics_PrimitiveArrayVariable_0_1_n_f32_ARRAY_CAPACITY_);
+    TEST_ASSERT_EQUAL(OVERRIDE_SIZE, sizeof(ref.n_f32.elements) / sizeof(ref.n_f32.elements[0]));
 #else
     TEST_ASSERT_EQUAL(sizeof(ref.a_u64.elements[0]) *
                       regulated_basics_PrimitiveArrayVariable_0_1_a_u64_ARRAY_CAPACITY_,