Add DDS IDL Namespace Primitives and Normalize DdsDcpsCore.idl
#3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are defined in XTypes 1.3 Table 43. They are specified in the context of the language binding, but makes more sense for them to be defined in IDL.
mitza-oci
reviewed
Jan 20, 2023
Also:
- Some cleanup in be_global that was going to come with some
additional code to inject the `using namespace IDLv4;` like the
includes are, but that ended up being unnecessary because of
be_produce.
- Fix problem compiling dds/CORBA/tao/Exception.cpp with TAO 3.
mitza-oci
approved these changes
Jan 24, 2023
|
Please update .gitignore per https://github.com/OpenDDS/OpenDDS/actions/runs/3993119111/jobs/6850668496#step:12:11 |
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Jan 25, 2023
OpenDDS#3994 - Fixed missing `TAO_VERSION_CODE` on TAO 2.2 by using `TAO_MAJOR_VERSION` instead. - Replaced reference to bugzilla ticket with DOCGroup/ACE_TAO#2037 - Cleaned up and added sorting option for `update_gitignore.pl` used in OpenDDS#3994 - Replaced sprintf usage to satisfy build_m12_i0_j_FM-1f GHA warnings
mitza-oci
added a commit
that referenced
this pull request
Apr 26, 2024
Add `DDS` IDL Namespace Primitives and Normalize `DdsDcpsCore.idl` (cherry picked from commit 69c8d1f) # Conflicts: # dds/DdsDcpsCore.idl # dds/idl/be_produce.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are defined in XTypes 1.3 Table 43. They are specified in the context of the C++ language binding, but it makes more sense for them to be defined in IDL.