Follow up to 3994 and Fix sprintf Warnings #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenDDS#3994 - Fixed missing `TAO_VERSION_CODE` on TAO 2.2 by using `TAO_MAJOR_VERSION` instead. - Replaced reference to bugzilla ticket with DOCGroup/ACE_TAO#2037 - Cleaned up and added sorting option for `update_gitignore.pl` used in OpenDDS#3994 - Replaced sprintf usage to satisfy build_m12_i0_j_FM-1f GHA warnings
mitza-oci
approved these changes
Jan 26, 2023
For ManyTopicTest the string in Foo3 appears to be missing a null terminator: https://github.com/OpenDDS/OpenDDS/actions/runs/4015514096/jobs/6899467008#logs This fix is assuming that the static buffer is causing the issue because there can multiple threads using the function.
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Jan 30, 2023
Follow up to OpenDDS#4003
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Jan 30, 2023
Follow up to OpenDDS#4003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3994
TAO_VERSION_CODEon TAO 2.2 by usingTAO_MAJOR_VERSIONinstead.update_gitignore.plused in AddDDSIDL Namespace Primitives and NormalizeDdsDcpsCore.idl#3994