-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
legend.onAdd = function ( map ) { | ||
|
||
var div = L.DomUtil.create('div', 'info legend'), | ||
grades = [10, 50, 100, 300], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these may need to be adjusted since we have polygons classed as 10-50 but the value is 0.
_pages/en/index.md
Outdated
@@ -39,10 +39,10 @@ Welcome to the OpenDRR data download site. Here you will find the latest version | |||
</div> | |||
<hr> | |||
<div class="row mrgn-tp-xl mrgn-btm-xl"> | |||
<div class="col-md-4 col-md-push-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a design element taken from RiskProfiler but if you prefer to see it all left aligned that's okay with me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to change that at all. I was just making the english and french versions match, and the french was missing that. I didn't notice the change because it looks exactly the same when the window is on half my screen. Thanks for pointing that out.
_pages/en/nhsl.md
Outdated
background-color: #f9f4d4; | ||
} | ||
</style> | ||
<script src="../assets/script.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I would create a folder for the scripts: assets/js/script.js. Typically, this would be called app.js.
@@ -95,58 +110,49 @@ breadcrumbs: | |||
<td>GitHub repository</td> | |||
<td class="hidden-xs">Document</td> | |||
<td><span class="label HTML">HTML</span></td> | |||
<td><a href="https://github.com/OpenDRR/earthquake-scenarios/blob/master/FINISHED/{{scenario.name}}.md" class="btn btn-primary">{{btntxt}}</a></td> | |||
<td><a href="https://github.com/OpenDRR/earthquake-scenarios/blob/master/FINISHED/{{ scenario.name }}.md" class="btn btn-primary">{{ btntxt }}</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do this like we do for NHSL with a resources section for each scenario in the YAML? Might be easier to maintain in the future.
assets/script.js
Outdated
@@ -0,0 +1,13 @@ | |||
let layers = [ 'nhsl_risk_dynamics_indicators', 'nhsl_social_fabric_indicators', 'nhsl_physical_exposure_indicators', 'nhsl_hazard_threat_indicators'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe have this as a function and pass the layers in from the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for your consideration.
@jvanulde Fixed all changes except for dsra resources in yaml. Should I be including the Gemfile changes? They were necessary to get it running on windows, not sure if they should be there. |
Attributes added to nhsl maps
dsra maps added
pygeoAPI endpoints added to resources
URL text to link function added to dsra.md
Closes #60, closes #58, closes #43