Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Dsra maps #68

Merged
merged 22 commits into from
Oct 21, 2021
Merged

Dsra maps #68

merged 22 commits into from
Oct 21, 2021

Conversation

DamonU2
Copy link
Contributor

@DamonU2 DamonU2 commented Oct 18, 2021

Attributes added to nhsl maps
dsra maps added
pygeoAPI endpoints added to resources
URL text to link function added to dsra.md

Closes #60, closes #58, closes #43

@DamonU2 DamonU2 requested a review from jvanulde October 18, 2021 22:38
@DamonU2 DamonU2 self-assigned this Oct 18, 2021
legend.onAdd = function ( map ) {

var div = L.DomUtil.create('div', 'info legend'),
grades = [10, 50, 100, 300],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these may need to be adjusted since we have polygons classed as 10-50 but the value is 0.

@@ -39,10 +39,10 @@ Welcome to the OpenDRR data download site. Here you will find the latest version
</div>
<hr>
<div class="row mrgn-tp-xl mrgn-btm-xl">
<div class="col-md-4 col-md-push-8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a design element taken from RiskProfiler but if you prefer to see it all left aligned that's okay with me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to change that at all. I was just making the english and french versions match, and the french was missing that. I didn't notice the change because it looks exactly the same when the window is on half my screen. Thanks for pointing that out.

background-color: #f9f4d4;
}
</style>
<script src="../assets/script.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I would create a folder for the scripts: assets/js/script.js. Typically, this would be called app.js.

@@ -95,58 +110,49 @@ breadcrumbs:
<td>GitHub repository</td>
<td class="hidden-xs">Document</td>
<td><span class="label HTML">HTML</span></td>
<td><a href="https://github.com/OpenDRR/earthquake-scenarios/blob/master/FINISHED/{{scenario.name}}.md" class="btn btn-primary">{{btntxt}}</a></td>
<td><a href="https://github.com/OpenDRR/earthquake-scenarios/blob/master/FINISHED/{{ scenario.name }}.md" class="btn btn-primary">{{ btntxt }}</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this like we do for NHSL with a resources section for each scenario in the YAML? Might be easier to maintain in the future.

assets/script.js Outdated
@@ -0,0 +1,13 @@
let layers = [ 'nhsl_risk_dynamics_indicators', 'nhsl_social_fabric_indicators', 'nhsl_physical_exposure_indicators', 'nhsl_hazard_threat_indicators']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have this as a function and pass the layers in from the page.

Copy link
Contributor

@jvanulde jvanulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for your consideration.

@DamonU2
Copy link
Contributor Author

DamonU2 commented Oct 19, 2021

@jvanulde Fixed all changes except for dsra resources in yaml. Should I be including the Gemfile changes? They were necessary to get it running on windows, not sure if they should be there.

@jvanulde jvanulde merged commit 9ae6253 into OpenDRR:main Oct 21, 2021
@DamonU2 DamonU2 deleted the dsra-maps branch November 15, 2021 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants