Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove celery from gaia #110

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Conversation

danlipsa
Copy link
Collaborator

No description provided.

@danlipsa
Copy link
Collaborator Author

@aashish24 @matthewma7 Please review.

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage increased (+0.9%) to 72.877% when pulling 809cfd9 on danlipsa:remove-celery into 73dde64 on OpenDataAnalytics:master.

@@ -10,7 +10,6 @@
romanesco_net_interface: eth0

romanesco_main_app_name: romanesco

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashish24 I am just curious what romanesco is, I think it's the old name for girder worker?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashish24 would know.

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage increased (+0.9%) to 72.877% when pulling cbba835 on danlipsa:remove-celery into 73dde64 on OpenDataAnalytics:master.

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage increased (+0.9%) to 72.877% when pulling c1fa6aa on danlipsa:remove-celery into 73dde64 on OpenDataAnalytics:master.

@jeffbaumes
Copy link

Yes - romanesco was renamed to girder_worker and has been reworked considerably since then.

@aashish24
Copy link
Collaborator

@matthewma7 we were using romanesco before and now since we decided (and are using) to use girder worker we can remove it.

Copy link
Collaborator

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @matthewma7 is happy with this PR.

Copy link

@matthewma7 matthewma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM and the code works for me.

@danlipsa
Copy link
Collaborator Author

@aashish24 @matthewma7 I think I don't have write access to this repo so I don't see a merge button.

@aashish24
Copy link
Collaborator

@danlipsa not sure what happened - I thought we added you..but here is the invite: https://github.com/OpenDataAnalytics/gaia/invitations

@danlipsa danlipsa merged commit ccd2e58 into OpenDataAnalytics:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants