Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Transform" section, with merge indicators by title #1369

Merged
merged 2 commits into from Jun 9, 2022
Merged

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented May 18, 2022

There's now a dev deploy of this at http://merge-indicator.dev.cove.opendataservices.coop/data/f8074830-45f1-4caa-a3b6-ebb4a2c21d30

I've added a "Transform" block that's collapsed by default:

Screenshot from 2022-05-18 14-05-11

This is what it looks like expanded:

Screenshot from 2022-05-18 14-05-22

After hitting the Run button:

Screenshot from 2022-05-18 14-20-19

This is all on one line, with a view to adding extra Transforms in the future.

@stevieflow How does this look? Are you happy with this Transform block being visible to all users? If you want we can write some text to go into the block to explain what it is.

@Bjwebb Bjwebb marked this pull request as draft May 18, 2022 13:25
@Bjwebb Bjwebb requested a review from rhiaro May 18, 2022 13:25
@Bjwebb
Copy link
Member Author

Bjwebb commented May 18, 2022

@rhiaro This depends on this iati-utils PR OpenDataServices/iati-utils#9

@stevieflow
Copy link
Member

I tested this and confirm it works as expected

@stevieflow How does this look? Are you happy with this Transform block being visible to all users? If you want we can write some text to go into the block to explain what it is.

Yes, all good. Ill write this text in a new issue, with a couple of other observations - but this does not need to block the PR

@Bjwebb Bjwebb marked this pull request as ready for review May 24, 2022 14:56
@Bjwebb Bjwebb merged commit 8700d87 into live Jun 9, 2022
@Bjwebb Bjwebb deleted the merge-indicator branch June 9, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants