Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merge_indicator to be imported and used as a library #9

Merged
merged 1 commit into from
May 23, 2022

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented May 17, 2022

This change is necessary to allow the merge_indicator function to be run as a standard function. Otherwise, it tries to parse commandline arguments.

@Bjwebb
Copy link
Member Author

Bjwebb commented May 19, 2022

@Lathrisk Could you take a look at the change I've needed to make here? As far as I can tell this is necessary to use this as both an importable function, and a command line one. If we're happy with this, we would ideally do the same for each of the functions.

Copy link
Contributor

@Lathrisk Lathrisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bjwebb Bjwebb merged commit 704fa58 into main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants