Fix 19 - Forward to country landingpage if top topics not set for country #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 26, 2016 14:34
| def check_top_topics_disabled(country_code): | ||
| for item in disabled_top_topic_links: | ||
| if item == country_code: | ||
| return True |
There was a problem hiding this comment.
@acorbi
is this a valid python approach?
There was a problem hiding this comment.
What I understand here is that you want to be able to specify certain country codes (i.e kh, vi,...) in a config variable named ckan.odm_nav_concept.disable_top_topic_links_for_countries in order to not show top topics menu in certain sites? If so, yes, looks consistant,
👍
chris-aeviator
pushed a commit
that referenced
this pull request
Feb 29, 2016
Fix 19 - Forward to country landingpage if top topics not set for country
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check proposed implementation and if https://github.com/OpenDevelopmentMekong/ckanext-odm_nav/compare/fix-19?expand=1#diff-46755a2818ff8b9c240c0ecf717e0b57R184 is a valid python approach ( not returning something if country_code is not in list )
For the proposed solution the setting
ckan.odm_nav_concept.disable_top_topic_links_for_countries = laos myanmar vietnam thailandhas been added to the ckan configuration file