Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): initialize with config model value #1271

Closed
wants to merge 4 commits into from

Conversation

Tibiritabara
Copy link

Currently, the model initialized in the agent, is taking a default value from args despite the user customization on the toml or the env vars.

This PR just replaces that line, to take the value from the config instead.

Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the frontend--it prevents the user from setting the model in the frontend.

I realize this workflow is kind of confusing as-is--we're working on making it better

@rbren rbren closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants