fix(sandbox): mount_dir
for ssh_box
#1333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for
WORKSPACE_MOUNT_PATH
is None, which causes issues when try to map it into SSHBox.Right now,
SSHBox
first read forWORKSPACE_MOUNT_PATH
thenWORKSPACE_BASE
.Based on our README.md, it seems to me that both of these variable means the same thing. Can we merge them together into one variable (i.e., we keep
WORKSPACE_MOUNT_PATH
and removeWORKSPACE_BASE
)?