Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docker on forked pull requests #1450

Merged
merged 22 commits into from Apr 29, 2024
Merged

Run docker on forked pull requests #1450

merged 22 commits into from Apr 29, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Apr 29, 2024

This PR ensure docker runs on all pull requests, not just PRs from inside this repo.

It will only build, and not push--there are some permission errors w/ the latter

@rbren rbren marked this pull request as ready for review April 29, 2024 13:29
@rbren rbren changed the title Run docker on pull requests Run docker on forked pull requests Apr 29, 2024
@rbren
Copy link
Collaborator Author

rbren commented Apr 29, 2024

Can't figure out the permissions unfortunately--going to un-require this check for now

@rbren rbren marked this pull request as draft April 29, 2024 15:38
@rbren rbren marked this pull request as ready for review April 29, 2024 15:45
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked basically good to me, I can take another look when tests pass.

containers/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@rbren rbren merged commit 11d48cc into OpenDevin:main Apr 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants