New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run docker on forked pull requests #1450
Conversation
Can't figure out the permissions unfortunately--going to un-require this check for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looked basically good to me, I can take another look when tests pass.
Co-authored-by: Graham Neubig <neubig@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
This PR ensure docker runs on all pull requests, not just PRs from inside this repo.
It will only
build
, and notpush
--there are some permission errors w/ the latter