Minor docstring & prompt fixes for AgentSkills #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-boxuan
commented
May 24, 2024
| @@ -58,7 +58,7 @@ def _lint_file(file_path: str) -> Optional[str]: | |||
| ret = 'ERRORS:\n' | |||
| ret += result.stdout.decode().strip() | |||
| return ret.rstrip('\n') | |||
| # Linting skipped. Either the file is not a Python file or auto-linting is disabled. | |||
| # Not a python file, skip linting | |||
There was a problem hiding this comment.
reason for this change: we already checked auto-linting before entering this function
li-boxuan
commented
May 24, 2024
| @@ -50,8 +50,8 @@ edit_file(start: int, end: int, content: str) -> None: | |||
| Edit a file. | |||
| It replaces lines `start` through `end` (inclusive) with the given text `content` in the open file. Remember, the file must be open before editing. | |||
| Args: | |||
| start: int: The start line number. Must be greater or equal to 1. | |||
| end: int: The end line number. Must be greater or equal to 1 AND greater than start AND less than or equal to the number of lines in the file. | |||
There was a problem hiding this comment.
greater than start
Reason for this fix: this is wrong. end could be equal to start.
There was a problem hiding this comment.
Also, I am not sure if LLM would have trouble understanding the precedences of "AND" and "or" here. LLM seems to be doing well but I am hoping a more formal statement makes it more clear.
xingyaoww
approved these changes
May 24, 2024
| @@ -50,8 +50,8 @@ edit_file(start: int, end: int, content: str) -> None: | |||
| Edit a file. | |||
| It replaces lines `start` through `end` (inclusive) with the given text `content` in the open file. Remember, the file must be open before editing. | |||
| Args: | |||
| start: int: The start line number. Must be greater or equal to 1. | |||
| end: int: The end line number. Must be greater or equal to 1 AND greater than start AND less than or equal to the number of lines in the file. | |||
| @@ -12,7 +12,7 @@ | |||
| - search_dir(search_term, dir_path='./'): Searches for a term in all files in the specified directory. | |||
| - search_file(search_term, file_path=None): Searches for a term in the specified file or the currently open file. | |||
| - find_file(file_name, dir_path='./'): Finds all files with the given name in the specified directory. | |||
| - edit_file(path, start, end, content): Replaces lines in a file with the given content. | |||
There was a problem hiding this comment.
Thanks for spotting the typo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1941