This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
game_control: HUD refactor #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
game_controls slowly becomes a superclass that does too many things. So move HUD into it's own class. This is the first step of getting the renderer out of game_controls (OpenDiablo2#798)
consts only used in hud should live there.
|
@juander-ux MVP! |
gravestench
approved these changes
Nov 5, 2020
|
@juander-ux would you mind joining our discord server? https://discord.gg/pRy8tdc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is the first step in merging the ui systems (#861) we have, as well as getting rid of the renderer in game_controls (#798). Here I rip the HUD out the game_control class as game_control was clearly doing to much.
cheers,