Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pdal matrix transform pipeline, updated PDAL version #571

Merged
merged 2 commits into from
May 11, 2017

Conversation

pierotofy
Copy link
Member

Fixes #522. Upgrades PDAL to include the changes to use double precision in the PLY reader.

@dakotabenjamin
Copy link
Member

This will also see improvements in the DEM progressive morphological filter.

@dakotabenjamin
Copy link
Member

I got this error:

[DEBUG]   running /home/dmb2/opendronemap/SuperBuild/build/pdal/bin/pdal pipeline /home/dmb2/ODMProjects/bluffs/odm_georeferencing/dem.json --readers.las.filename=/home/dmb2/ODMProjects/bluffs/odm_georeferencing/odm_georeferenced_model.las --writers.gdal.filename=/home/dmb2/ODMProjects/bluffs/odm_georeferencing/odm_georeferencing_model_dem.tif
PDAL: filters.pmf: Unexpected argument 'extract'.

Traceback (most recent call last):
  File "/home/dmb2/opendronemap/run.py", line 46, in <module>
    plasm.execute(niter=1)
  File "/home/dmb2/opendronemap/scripts/odm_georeferencing.py", line 183, in process
    self.params.gdal_radius)
  File "/home/dmb2/opendronemap/opendm/types.py", line 240, in convert_to_dem
    '--writers.gdal.filename={f_out}'.format(**kwargs))
  File "/home/dmb2/opendronemap/opendm/system.py", line 28, in run
    raise Exception("Child returned {}".format(retcode))
Exception: Child returned 1

Here's my json file:

{
    "pipeline":[
        "input.las",
    {
        "type":"filters.sample",
        "radius":"1.0"
    },
    {
        "type":"filters.pmf",
        "extract":"true"
    },
    {
        "resolution": 2,
        "radius": 0.5,
        "output_type":"idw",
        "filename":"outputfile.tif"
    }
    ]
}

@dakotabenjamin
Copy link
Member

dakotabenjamin commented May 10, 2017

Simply removing the "extract":"true" line fixed it

Now it doesn't extract... Need to add:

{
  "type":"filters.range",
  "limits":"Classification[2:2]"
}

@dakotabenjamin
Copy link
Member

Here's a patch:

From 1efd7cb859363b505f3a479853b7495d8ae5cb7d Mon Sep 17 00:00:00 2001
From: Dakota Benjamin <dmb2@clevelandmetroparks.com>
Date: Wed, 10 May 2017 15:32:12 -0400
Subject: [PATCH] Update dem pipeline to latest pdal specs

---
 opendm/types.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/opendm/types.py b/opendm/types.py
index 6ed5773..54892e9 100644
--- a/opendm/types.py
+++ b/opendm/types.py
@@ -221,8 +221,11 @@ class ODM_GeoRef(object):
                        '        "radius":"{sample_radius}"' \
                        '    }},' \
                        '    {{' \
-                       '        "type":"filters.pmf",' \
-                       '        "extract":"true"' \
+                       '        "type":"filters.pmf"' \
+                       '    }},' \
+                       '    {{' \
+                       '      "type":"filters.range",' \
+                       '      "limits":"Classification[2:2]"' \
                        '    }},' \
                        '    {{' \
                        '        "resolution": {gdal_res},' \
-- 
2.7.4

@pierotofy
Copy link
Member Author

Thanks for the patch! I committed it. Let me know if you find other issues!

@dakotabenjamin
Copy link
Member

dakotabenjamin commented May 11, 2017

croppercapture 26

croppercapture 27

@dakotabenjamin dakotabenjamin merged commit 88aa02e into OpenDroneMap:master May 11, 2017
peddyhh pushed a commit to peddyhh/ODM that referenced this pull request Jun 7, 2020
Updated pdal matrix transform pipeline, updated PDAL version

Former-commit-id: 88aa02e
pierotofy pushed a commit that referenced this pull request Sep 21, 2020
Updated pdal matrix transform pipeline, updated PDAL version

Former-commit-id: 88aa02e
@pierotofy pierotofy deleted the lasstripes branch September 21, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants