Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding stylistic eslint plugin to ui project #2671

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

miettal
Copy link
Contributor

@miettal miettal commented Jun 14, 2024

This PR migrate eslint formatting rules to stylistic plugin rules.

// current eslint version of this project is "eslint": "^8.57.0",. this means currently eslnt formatting check is not working, I think. // ^8.41 → ^8.57 bump is happen on #2623

The below text is the background to this problem.

last year, eslint deprecated formatting rules in v8.53.0 release.

https://eslint.org/blog/2023/11/eslint-v8.53.0-released/

Core formatting rules have been deprecated.

https://eslint.org/blog/2023/10/deprecating-formatting-rules/

The next minor release of ESLint will deprecate core formatting rules. We recommend you use a source code formatter instead.

And also they mentioned stylistic eslint plugin for migration.

If the idea of using a dedicated source code formatter doesn’t appeal to you, you can also use @stylistic/eslint-plugin-js for JavaScript or @stylistic/eslint-plugin-ts for TypeScript. These packages contain the deprecated formatting rules from the ESLint core and typescript-eslint, respectively. The packages are maintained by Anthony Fu, who has decided to continue maintaining these rules going forward. If you’d like to continue using the rules mentioned in this post, then we recommend switching to these packages.

Copy link

Code Coverage

Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've been wondering why it did not work anymore 👍

@sfeilmeier sfeilmeier merged commit 54dcd4e into OpenEMS:develop Jun 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants