Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for updating directly from GitHub #562

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

jeremypoulter
Copy link
Collaborator

@jeremypoulter jeremypoulter commented Mar 8, 2023

Fixes #259
Fixes #502

@jeremypoulter jeremypoulter changed the title Support for updating directly fromG Support for updating directly from GitHub Mar 8, 2023
@KipK
Copy link
Collaborator

KipK commented Mar 8, 2023

Great , thanks for this. I'm enabling it on the UI

@KipK
Copy link
Collaborator

KipK commented Mar 8, 2023

@KipK
Copy link
Collaborator

KipK commented Mar 8, 2023

Perhaps one catch here.

http_update_end doesn't seems to be called at the end ( or missing test if(Update.end(true)) ). not sure but the event["ota"] = "completed" is not published so I suspect this is the case

update doesn't fail btw

@jeremypoulter
Copy link
Collaborator Author

Will take a look

@KipK
Copy link
Collaborator

KipK commented Mar 9, 2023

@jeremypoulter, forget it it works. It was testing the wrong ui branch

@KipK
Copy link
Collaborator

KipK commented Mar 10, 2023

for proper integration of having daily builds downloaded from the gui v2, I'll wait for ui v2 migration on next major release.
It will need to have the same file names as release to be consistant or at least not 2 versions ( unless we consider we want to keep 2 UI for mid term transitions , but a bit of a pain to maintain )
We should also add the hashed version number as tag instead of "latest" on github this will feed the tag_name properties in :
https://api.github.com/repos/OpenEVSE/ESP32_WiFi_V4.x/releases
and can be used to compare versions on the gui.

@jeremypoulter jeremypoulter merged commit 6ecd665 into master Mar 10, 2023
@jeremypoulter jeremypoulter deleted the jeremypoulter/issue259 branch March 23, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP 302 Redirection Support upgrade directly from GitHub
2 participants