Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for working on different timezones #614

Merged
merged 2 commits into from May 1, 2023
Merged

Conversation

jeremypoulter
Copy link
Collaborator

maketime uses local time so changed to timegm so the input and output times are GMT

jeremypoulter and others added 2 commits May 1, 2023 20:47
maketime uses local time so changed to timegm so the input and output times are GMT
@jeremypoulter jeremypoulter requested a review from KipK May 1, 2023 19:48
@jeremypoulter
Copy link
Collaborator Author

@KipK Please take a look, should fix the time zone issues with the divert sim

@KipK
Copy link
Collaborator

KipK commented May 1, 2023

Date is good now, but I still get failed test:

(...)
01/01/2020 23:45:00,0,0,0,0,1440,254,0.0756085                | 01/01/2020 23:45:00,0,0,0,0,1440,254,0.0756085
Test Energy_and_Power_Day_2020-04-01 failed
Passed 0 tests, failed 12 tests

edit: comparing snapshot & output files, they're all strictly the same, I wonder why it failed in diff compare

@KipK
Copy link
Collaborator

KipK commented May 1, 2023

using -Z ( ignore trailing space ) on diff command solve the problem

@jeremypoulter
Copy link
Collaborator Author

I wonder where the trailing spaces are coming from....

@KipK
Copy link
Collaborator

KipK commented May 1, 2023

when comparing files manually they don't have any trailing space, that's strange

@KipK
Copy link
Collaborator

KipK commented May 1, 2023

could be from WSL and EOL git conversion messup

@jeremypoulter
Copy link
Collaborator Author

Yeah that could be it

@KipK KipK merged commit bfcacf7 into master May 1, 2023
33 checks passed
@jeremypoulter jeremypoulter deleted the divert_sim_timezone_fix branch May 12, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants