Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke this into individual commits in case any of them are seen as undesirable.
For full disclosure- I will next try and implement OpenEVSE/ESP8266_WiFi_v2.x#160 in this repository, but wanted to ensure there was no concerns about asset bloat. By reducing the current assets in size by 8KB, I figured adding additional assets would be more acceptable.
Here are the two meaningful commits and descriptions:
Run optipng on favicon-32x32 to shrink size
The 16x16 favicon was already fully optimized, but the 32x32 image was
not. This saves 142 bytes, which isn't much, but very little reason not
to do so.
Run
svgo
SVG optimizer on wifi imagesThese XML files contain a bunch of inkscape metadata that is not needed
to render the image. Use the svgo utility (https://github.com/svg/svgo)
with default options to remove all unnecessary bits from the files,
saving roughly 8 KB across the five images.
Obviously it is possible I missed something, but I did a visual
verification that nothing changed in the rendering of these images. I
cannot test in every possible browser, however.
You can do the "rich diff" option in Github on this PR to view the old and new images side by side.