OECoreUpdater: check min OS Version requirement on uninstalled cores. #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is okay except that here https://github.com/OpenEmu/OpenEmu/pull/2293/files#diff-00b7303d2a4bf81bc539f57cb9cf16a5R474 you cannot compare the string @"" with ==, need to use isEqualToString: instead. |
|
Okay, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully make future OE OS version requirement bumps more friendly.
A more complete explanation is:
Since Sparkle's update checking logic is all in the SUUpdater, which is tied to an existing bundle (which doesn't exist, since it hasn't been installed yet), it's necessary to reproduce the operating system version requirement check in OpenEmu. There is no existing version to check against. This code assumes that the newest versions are always ordered first in the appcast. As a result, maximum system version checks are not implemented.