style: Fix whitespace and quotes formatting #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| database: process.env.OED_DB_TEST_DATABASE | ||
| host: process.env.POSTGRES_HOST, | ||
| port: process.env.POSTGRES_PORT, | ||
| user: 'postgres', |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
huss
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks to @hyperupcall for another task completed. This has also annoyed me so I appreciate the change. Everything looks good.
For other developers: OED will do an npm install because of spacing changes in the package files. However, there are not actual changes to the packages.
|
Note the CodeQL error is not new and needs to be dealt without outside this pull request. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the ESLint VScode extension, many files will have red squigly lines, which represent formatting errors. This may be a source of confusion for people new to the codebase.
Additionally, the EditorConfig file is not configured to configure an
indent_typespacefor files that require it or should use it, such as yaml and markdown.This fixes both of those situations, fixing the inconsistent whitespace.
Related to #879 (f9d328c, e35768e, and a4e0244)
Type of change
Checklist
Limitations
N/A