Set reading to float #776
Set reading to float #776
Conversation
|
I just want to leave a record that I searched all SQL uses of real and found these:
Given their usage they are probably fine at 32-bit so they are not being changed now. |
- If you already had the compare functions then they must be dropped before created since signature changed. I added the drop just to be careful. - Added comments to migration files about dropping & refreshing views if doing manually.
There was a problem hiding this comment.
This works fine and as intended. I did not do a full migration but tested each migration individually. I push a few small changes to clarify about order and needed operations before alters/creates. Can @truongdd03 look at them to make sure they are okay?
I note that I realized you have to refresh the reading views after the migration since there are new views. That will be dealt with separately.
I think this is ready to merge after my changes are checked.
|
Thank you for your review and addition, @huss. New changes look good to me so I think the PR can be merged now. |
Description
Testing found that the space and access time are acceptable when changing the reading type from real (32-bits) to float (64-bit). This PR makes this change for the reading table and functions using these values. DB migration is also created. I have done a full migration and it works as expected on my machine.
Fixes #650
Type of change
Checklist
Limitations