Minor MD bug fixes: Bathymetry #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Fixes typos in warnings printed when reading Input files. Adds backwards compatibility for older MD input files that still use Connection/Con instead of Point in output channels. Fixes two bugs in bathymetry files with MD: allocating the bathymetry grid now matches the input file format (Y = rows, X = columns), fixed a typo in the logic that calculates the normal to the seabed slope which was causing nan's.
Related issue, if one exists
n/a
Impacted areas of the software
MoorDyn
Additional supporting information
As discussed with @mattEhall and @luwang00.
Note that bathymetry bugs are also present in v 3.5.2 and should be back ported into 3.5.3 release.
Test results, if applicable
n/a