Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: clarifying installer text #475

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

jennirinker
Copy link
Contributor

Complete this sentence
THIS PULL REQUEST __ IS NOT __ READY TO MERGE

Requires review from the gurus. ;)

Feature or improvement description
Adding clarifying text regarding the installation of the MKL libraries.

The release text could then say something like "Note that these binaries require the MKL libraries to be installed. See Sec. 2.1 in the documentation for more detail."

Related issue, if one exists
Issue #474

Impacted areas of the software
docs source, install.rst. See the changes in the commit.

Additional supporting information
You guys are rockstars.

Test results, if applicable
None.

@rafmudaf rafmudaf changed the base branch from master to dev June 24, 2020 19:59
@andrew-platt andrew-platt self-requested a review June 24, 2020 19:59
Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve! We'll just need to update this text if we change compiler version for distribution (though the libraries seem to be somewhat cross compatible, so maybe it won't present an issue).

@andrew-platt andrew-platt merged commit ce93f7c into OpenFAST:dev Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants