InflowWind: Return if fatal error occurs in FFWind_Base::GetInterpValues #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid index - the GetInterpValues() routine in IfW_FFWind_Base.f90 checks the bounds of the FF in the y direction and sets an error. However, we should exit at that point before attempting to read from an invalid location outside the p%FFData array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge
Feature or improvement description
The
GetInterpValues()routine inIfW_FFWind_Base.f90checks the bounds of the full field wind data in the y direction and sets an error. However, the array was accessed immediately afterwards potentially with an invalid index to the array and may trigger a segmentation fault.A check was added to ensure that no fatal errors occured in the
GetInterpValues()call and return at that point before attempting to read from an invalid location outside thep%FFDataarray.Related issue, if one exists
No known issues. This showed up in testing of the LidarSim module in development.
Impacted areas of the software
InflowWind full field wind interpolation only. And only if outside the bounds.
Test results, if applicable
No tests will be affected.