Meta annotations support #30
Conversation
There was a problem hiding this comment.
Can you add a "how-to" or so on the readme - explaining what the usecase is and how to use it (I get how it works and reduces what would otherwise likely be boiler-plate code)?
Also - is the expectation that you use the meta annotations OR the explicit ones (but not both at the same time?) Not sure how they're meant to interact, but if they don't play well, we either need to make them play well with eachother (with test cases) or make sure that we are explicit in our How-to as well as add cases that force us not to mix-and-match (I picture when someone wants a generic version of handling a given set of standard errors - but a specific code on a specific class should generate something else and hence they add the meta-annotation plus one code on error handling... - what would then be the expected behaviour?
|
will improve it |
|
@saintf i added some more test cases and also added the meta-annotations support to the README, would be nice if you can check again and let me know about further improvements |
|
the PR is now also against master as it is easier to add this functionality |
meta-annotations on meta-annotations are not supported
|
@saintf anything left here that i need to improve? |
|
has been merged into the official repo OpenFeign/feign#1457 |
this is a pull request against 1.0.3 to support meta-annotations when trying to find the
@ErrorHandlingannotation on a class/interface or methodit would be really nice if this can be merged against 1.0.3 and a new 1.0.4 will be released because we can not upgrade to OpenFeign 10.x right now
this will fix #31