-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainer gone for OpenFeign/feign-annotation-error-decoder? #1447
Comments
To be honest, I didn't even knew this repo existed. @kdavisk6 and I adopted feign after the original team moved to new and exiting projects. Kevin, what you think about folding this annotation-error-decoder into the main project as a module? @BigMichi1 would that help? Are you willing to create the PR on the main project instead? |
sure i can recreate the pr |
Makes a lot of sense. Feel free |
Awesome, please ping me once you have a PR ready. I can make sure to release it right after it's merged |
just to clearify some things before i'm doing it wrong
|
We usually include feign on module names on maven, so Target master for sure. Compatibility also master/latest and greatest. No need to keep history, as we squash merge. You can if you really want to, but most will be lost when we first merge button. @kdavisk6 any strong opinion here? Shall we not squash this one?! Having you change in a separated PR sounds like a solid plan. |
* #1447 import https://github.com/OpenFeign/feign-annotation-error-decoder import of master at commit 546752425238f3d42d0ceec91d5c5af05841803e * #1447 remove build files * #1447 include annotation-error-decoder into the build * #1447 adjust file header * #1447 add Annotation Error Decoder to the mindmap * #1447 remove links to old repo from README.md Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
it looks like there is no maintainer anymore for https://github.com/OpenFeign/feign-annotation-error-decoder. i opened there a pull request but no one approved the requested changes. looks like @saintf is not there anymore. can this repo be reactivated?
The text was updated successfully, but these errors were encountered: