fix inconsistent bug #1137
Merged
fix inconsistent bug #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we both use bodyParams and formParam.
if `formParam param's order` before `bodyParams param's order` Feign will throw exception message `Body parameters cannot be used with form parameters.`.
Bug if `formParam param's order` after `bodyParams param's order` Fegin not throw exception,it is `inconsistent`.
test code like:
```java
@RequestLine("POST /")
void formParamAndBodyParams(
@param("customer_name") String customer,
String body);
@RequestLine("POST /")
void bodyParamsAndformParam(
String body,
@param("customer_name") String customer);
```
build this two method see.
switchYello
changed the title
kdavisk6
approved these changes
Dec 27, 2019
kdavisk6
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to test case，if we use Fegin like:
Fegin will throw exception message
Body parameters cannot be used with form parameters..But we reverse params like:
Fegin not throw exception , only ignore
formParams, so it is inconsistent.This PR fix this inconsistent , always check
Body parametersandform parameters.