Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent bug #1137

Merged
merged 1 commit into from Dec 30, 2019
Merged

fix inconsistent bug #1137

merged 1 commit into from Dec 30, 2019

Commits on Dec 25, 2019

  1. fix inconsistent bug

    when we both use bodyParams and formParam.
    if `formParam param's order` before `bodyParams param's order` Feign will throw exception message `Body parameters cannot be used with form parameters.`.
    
    Bug if `formParam param's order` after `bodyParams param's order` Fegin not throw exception,it is `inconsistent`.
    
    test code like:
    ```java
    
    @RequestLine("POST /")
    void formParamAndBodyParams(
            @param("customer_name") String customer,
            String body);
    
    @RequestLine("POST /")
    void bodyParamsAndformParam(
            String body,
            @param("customer_name") String customer);
    
    ```
    build this two method see.
    switchYello committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    fe1e368 View commit details
    Browse the repository at this point in the history