Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-57: Add Target Method Parameter Definition Model #64

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

kdavisk6
Copy link
Member

To better support compile time annotation processors, this change introduces the TargetMethodParameterDefinition model object. Used by our compile time annotation processor and eventually all Contract implementation, this object contains the configuration of an annotated method parameter.

To better support compile time annotation processors, this change introduces the TargetMethodParameterDefinition model object.  Used by our compile time annotation processor and eventually all Contract implementation, this object contains the configuration of an annotated method parameter.
@kdavisk6 kdavisk6 changed the title GH-57 Add Target Method Parameter Definition Model GH-57: Add Target Method Parameter Definition Model Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #64 (4fad8f3) into main (cba47c0) will increase coverage by 0.13%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #64      +/-   ##
============================================
+ Coverage     93.11%   93.24%   +0.13%     
- Complexity      655      667      +12     
============================================
  Files            75       76       +1     
  Lines          1714     1747      +33     
  Branches        186      187       +1     
============================================
+ Hits           1596     1629      +33     
  Misses           66       66              
  Partials         52       52              
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/feign/TargetMethodDefinition.java 95.16% <ø> (ø) 30.00 <0.00> (ø)
...in/java/feign/TargetMethodParameterDefinition.java 96.96% <96.96%> (ø) 11.00 <11.00> (?)
core/src/main/java/feign/support/Assert.java 60.00% <0.00%> (+6.66%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba47c0...4fad8f3. Read the comment docs.

@kdavisk6 kdavisk6 merged commit 503eaf3 into OpenFeign:main Mar 23, 2021
@kdavisk6 kdavisk6 deleted the GH-57-target-method-parameters branch March 23, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant