Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-57 Delegate Template Parameter creation to Method Handlers #66

Merged
merged 3 commits into from
Mar 28, 2021

Conversation

kdavisk6
Copy link
Member

Related to #57

This change moves TemplateParameter object creation to AbstractTargetMethodHandler to reduce the overhead of Contract parsing and reduce the responsibility of Contract implementations to class metadata and not collaborating object construction.

Related to OpenFeign#57

This change moves `TemplateParameter` object creation to `AbstractTargetMethodHandler` to reduce the overhead of `Contract` parsing and reduce the responsibility of `Contract` implementations to class metadata and not collaborating object construction.
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #66 (76f1cbc) into main (503eaf3) will decrease coverage by 0.20%.
The diff coverage is 91.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #66      +/-   ##
============================================
- Coverage     93.24%   93.03%   -0.21%     
- Complexity      667      676       +9     
============================================
  Files            76       76              
  Lines          1747     1781      +34     
  Branches        187      189       +2     
============================================
+ Hits           1629     1657      +28     
- Misses           66       73       +7     
+ Partials         52       51       -1     
Impacted Files Coverage Δ Complexity Δ
...ign/template/expander/CachingExpanderRegistry.java 91.30% <83.33%> (-8.70%) 12.00 <5.00> (+4.00) ⬇️
...n/java/feign/impl/AbstractTargetMethodHandler.java 97.27% <88.88%> (-1.68%) 33.00 <7.00> (+4.00) ⬇️
...in/java/feign/TargetMethodParameterDefinition.java 97.61% <92.30%> (+0.64%) 16.00 <3.00> (+5.00)
...re/src/main/java/feign/TargetMethodDefinition.java 95.16% <100.00%> (ø) 30.00 <0.00> (ø)
...ign/contract/AbstractAnnotationDrivenContract.java 97.05% <100.00%> (ø) 9.00 <0.00> (ø)
...re/src/main/java/feign/contract/FeignContract.java 97.10% <100.00%> (+0.13%) 19.00 <1.00> (-3.00) ⬆️
...n/java/feign/template/SimpleTemplateParameter.java 66.66% <0.00%> (-11.12%) 5.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503eaf3...76f1cbc. Read the comment docs.

@kdavisk6 kdavisk6 merged commit a9e1d81 into OpenFeign:main Mar 28, 2021
@kdavisk6 kdavisk6 deleted the GH-57-contract-refactor branch March 28, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant