Fix OpenMMForceFields gaff tests version checks #893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
For now I'm leaving the ommforcefields 0.13 check, this is so that we know the tests don't fail with older versions of OpenMM. Once the next version of OpenMMForceFields is out where gaff is supported with older OpenMM versions then we should remove these checks.
Checklist
news
entryDevelopers certificate of origin