support build from local source code #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wanjunlei <wanjunlei@kubesphere.io>
benjaminhuo
reviewed
Jan 31, 2023
| "must be specified when `spec.build` enabled") | ||
| } | ||
|
|
||
| if r.Spec.Build.SrcRepo.Url == "" && r.Spec.Build.SrcRepo.BundleContainer == nil { |
There was a problem hiding this comment.
Maybe we need to add a check to ensure only one of the URL or bundleContainer can be specified?
Not all of them can be set simultaneously.
There was a problem hiding this comment.
If bundleContainer and url are set at the same time, bundleContainer will be used first.
benjaminhuo
approved these changes
Jan 31, 2023
|
We need docs, helm charts for the revision-controller now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanjunlei wanjunlei@kubesphere.io