Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating KEDA http-addon #483

Merged
merged 18 commits into from
Sep 7, 2023
Merged

Integrating KEDA http-addon #483

merged 18 commits into from
Sep 7, 2023

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented Aug 18, 2023

No description provided.

@B1F030
correct Dapr Input
00c94a3 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
keda http-addon crd integrateed
2c5cdc1 
Signed-off-by: B1F030 <646337422@qq.com>
@benjaminhuo
Copy link
Member

image
@B1F030 You'll need to run make manifests

@B1F030
make generate synced
6b9c8c7 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
Copy link
Contributor Author

B1F030 commented Aug 19, 2023 •
edited
Loading

image @B1F030 You'll need to run make manifests

I have synced the code with my cluster now, and make verify successfully.
There may be some problems yet, and I will keep updating this PR.

@B1F030 B1F030 closed this Aug 19, 2023
@B1F030 B1F030 reopened this Aug 19, 2023
@B1F030
add httpscaledobject and ingress into config/rbac/role.yaml
0f8aaa9 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
change HttpRuntime const to HttpEngine
cd9d324 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
optimize the judgment logic in serving_controller.go
a2076b7 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
use goimports to sort the import
8c43f0d 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
optimized some judgment logic codes in apis/core/v1beta2/function_web…
25431c2 
…hook.go

Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
correct the judgment logic code
af32d3f 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
SetControllerReference for generated service
ef607a8 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
add some comments and a const called ingressName
3d5f553 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
remove service with async function
5cccc68 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
update proposal to latest version
10c50cc 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
KEDA http-addon reconcilation finished
ab78f26 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
complete function_webhook_test validate code for scaleOptions.keda
5fdbeda 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030
add validation for keda.httpScaledObject.cooldownPeriod
bea4e2d 
Signed-off-by: B1F030 <646337422@qq.com>
@B1F030 B1F030 mentioned this pull request Sep 7, 2023
Closed
benjaminhuo
benjaminhuo requested changes Sep 7, 2023
View reviewed changes
apis/core/v1beta2/function_webhook.go Outdated Show resolved Hide resolved
apis/core/v1beta2/function_webhook.go Outdated Show resolved Hide resolved
pkg/constants/constants.go Show resolved Hide resolved
@benjaminhuo
Copy link
Member

@B1F030 Thanks for this PR, it's great to have keda-http as another HTTP engine finally. Just some minor issues need to be resolved.

B1F030 and others added 2 commits September 7, 2023 22:29
@B1F030 @benjaminhuo
Update apis/core/v1beta2/function_webhook.go
557e8fa 
Co-authored-by: Benjamin Huo <huobj@qq.com>
@B1F030 @benjaminhuo
Update apis/core/v1beta2/function_webhook.go
2562235 
Co-authored-by: Benjamin Huo <huobj@qq.com>
@benjaminhuo benjaminhuo merged commit 92fe37b into OpenFunction:main Sep 7, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpiperatgod tpiperatgod tpiperatgod left review comments

@wanjunlei wanjunlei wanjunlei left review comments

@benjaminhuo benjaminhuo benjaminhuo approved these changes

@wrongerror wrongerror Awaiting requested review from wrongerror

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@B1F030 @benjaminhuo @tpiperatgod @wanjunlei