New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Messages.formatWithAttributes() append additional arguments #1802

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@wjnicholson
Contributor

wjnicholson commented Oct 1, 2018

Currently Messages.format() appends additional arguments to the end of the message, while
Messages.formatWithAttributes() discards them. This meant that the JavaDoc on several FailureItem.of() methods was incorrect, and is inconsistent in the class.
Now additional arguments without a placeholder will be appended to the message (and continue to be left out of the attributes).

@jodastephen jodastephen merged commit dc3304a into master Oct 1, 2018

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - modules/basics/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pricer/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma) No new issues
Details
security/snyk - pom.xml (OpenGamma) No new issues
Details

@jodastephen jodastephen deleted the topic/messages-consistent-formatting branch Oct 1, 2018

@jodastephen jodastephen added this to the v2.1 milestone Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment