Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Messages.formatWithAttributes() append additional arguments #1802

merged 1 commit into from Oct 1, 2018


Copy link

Currently Messages.format() appends additional arguments to the end of the message, while
Messages.formatWithAttributes() discards them. This meant that the JavaDoc on several FailureItem.of() methods was incorrect, and is inconsistent in the class.
Now additional arguments without a placeholder will be appended to the message (and continue to be left out of the attributes).

@jodastephen jodastephen merged commit dc3304a into master Oct 1, 2018
@jodastephen jodastephen deleted the topic/messages-consistent-formatting branch October 1, 2018 16:35
@jodastephen jodastephen added this to the v2.1 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants