freivalds_algorithm .cpp #3607
Open
freivalds_algorithm .cpp #3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavb
requested changes
Jun 18, 2018
| #include <iostream> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| using namespace std; |
| @@ -0,0 +1,104 @@ | |||
| /* | |||
There was a problem hiding this comment.
The location of this file is incorrect. Also, your file extension seems detached from the name.
|
|
||
| #include <iostream> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> |
| int n; | ||
| cin >> n; | ||
| cout << "Enter the 1st matrix: " << endl; | ||
| double a[n][n]; |
There was a problem hiding this comment.
Use std::vector, as variable length arrays (VLAs), are not part of standard C++.
| bool flag = true; | ||
| for (int i = 0; i < n; i++) | ||
| { | ||
| if (abr[i][0] == 0) |
There was a problem hiding this comment.
It would be clearer if:
{
if (abr[i] != 0)
flag = false
}| if (flag == true) | ||
| cout << "True"; | ||
| else | ||
| cout << "False"; |
There was a problem hiding this comment.
Please add newlines to the end of the output. Also, == true is a redundant condition.
| else | ||
| cout << "False"; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Changes: