solves issue #3488 #3660
Open
solves issue #3488 #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow the coding style guide and make changes according to it. |
mansiag
approved these changes
Oct 1, 2018
| ans += str(a % y) | ||
| a = a // y | ||
| return ans == ans[::-1] | ||
| ans =0 |
There was a problem hiding this comment.
add spaces between operator and operands
| a = a // y | ||
| return ans == ans[::-1] | ||
| ans =0 | ||
| while a!=0: |
| return ans == ans[::-1] | ||
| ans =0 | ||
| while a!=0: | ||
| ans=ans*10+a % y |
| while a!=0: | ||
| ans=ans*10+a % y | ||
| a = a // y | ||
|
|
| print(answer) | ||
|
|
mansiag
previously approved these changes
Oct 1, 2018
| @@ -12,7 +12,7 @@ def palindrome(x): | |||
| while x ! = 0: | |||
| reverse = reverse * 10 + x % 10 | |||
| x = x // 10 | |||
| if reverse==num: | |||
| if reverse = = num: | |||
mansiag
reviewed
Oct 1, 2018
| def base_check(a, y): | ||
| ans = 0 | ||
| while a ! = 0: | ||
| ans = ans * 10 + a % y |
mansiag
reviewed
Oct 1, 2018
| return x == x[::-1] | ||
| def base_check(a, y): | ||
| ans = 0 | ||
| while a ! = 0: |
changes made in the coding style
Changes made in the coding style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
This PR solves the issue #3488.Changes:
Changes made in the functions: base_check and palindrome .
Also binary with leading zeros are eliminated.