Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #3781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

done #3781

wants to merge 1 commit into from

Conversation

tarun-codestien
Copy link

No description provided.

Copy link
Member

@arnavb arnavb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this PR?

@arnavb
Copy link
Member

arnavb commented Feb 24, 2019

@tarun-codestien Please do not get rid of the working code already present for binary search. In addition, this code is directly copy/pasted from https://www.geeksforgeeks.org/binary-search/. Plagiarism will not be tolerated in our community.

In the end, please make sure to see if implementations are already present for an algorithm. If so, then consider refactoring it for improvement! We value your contributions, but we want to make sure it really is your contribution in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants