Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum the numbers in an array - elixir #3794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MariliaMJ
Copy link

Changes:
A file containing a simple sum of numbers in an array using elixir.

@MariliaMJ
Copy link
Author

This is not building, but I did not understand why. If anyone could help me with it, much appreciated.

@arnavb
Copy link
Member

arnavb commented Oct 15, 2018

Ignore the Travis CI for now; still in beta! 😝

Copy link
Member

@arnavb arnavb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code! You don't need the comment at the top of the file though.

Copy link
Member

@arnavb arnavb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this file is placed in the wrong location. The files in this folder currently find the indices of the two numbers that add up to a specific target. Your code just sums an array. In addition, it does not actually implement an algorithm, which would make it kind of useless for our repository. Please reflect these changes in your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants