added priority_queue.c #3798
Open
added priority_queue.c #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as your other PRs. |
removed header <conio.h>,global variable and fixed indentation errors
arnavb
requested changes
Oct 16, 2018
| @@ -0,0 +1,93 @@ | |||
| #include <stdio.h> | |||
|
|
|||
| int head = 0,tail = 0; | |||
There was a problem hiding this comment.
Is there any way you can avoid global variables here?
|
|
||
| else if (tail<max) { | ||
| queue[0][tail]=value; | ||
| queue[1][tail[=priority; |
There was a problem hiding this comment.
Type. Also, you need spaces after all commas in this file.
| void | ||
| dequeue(int max) | ||
| { | ||
| if (tail==0 || head==max) {\ |
There was a problem hiding this comment.
This code doesn't work. Why do you have braces in the first place? And why the backslash?
There was a problem hiding this comment.
that backslash and brace is a typo..!
| printf("queue is empty"); | ||
|
|
||
| else { | ||
| int i; |
| void | ||
| display() | ||
| { | ||
| int i; |
There was a problem hiding this comment.
No need for this to be at the top of the function.
| printf("queue is empty"); | ||
|
|
||
| else { | ||
| for (i=head;i<tail;i++) |
There was a problem hiding this comment.
why preincrement?
|
|
||
| else { | ||
| for (i=head;i<tail;i++) | ||
| { |
| int i; | ||
| if (tail==0) | ||
| printf("queue is empty"); | ||
|
|
There was a problem hiding this comment.
should i add a new line(after line 84) or should i remove it(line 84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
added code for priority queue which accepts values as per given priority