Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 4 #3821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Patch 4 #3821

wants to merge 4 commits into from

Conversation

TubaAli
Copy link

@TubaAli TubaAli commented Oct 17, 2018

Fixes issue:
Fixes #2910

Changes:
Update Readme.md file of DFS

Copy link

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
You seem to have mixed your commits.
Either roll back the commits or raise up another PR, altogether.
Also:

  • Always write a good title and a good commit message.
    (We don't get to know which file you've changed or added?)
  • Squash your commits into one.

Hoping to see it resolved at the earliest.

@arnavb
Copy link
Member

arnavb commented Oct 18, 2018

@utkarsh2102, you took the words right out of my mouth! 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants