Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted one copy of linked list #3975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rucha174
Copy link
Contributor

@rucha174 rucha174 commented Mar 9, 2019

Fixes issue:
fixes issue #3934

Changes:
As per issue #3934 there were duplicate linked list. Removed this one in cosmos/code/data_structures/src/linked_list
kept the other one which is at cosmos/code/data_structures/src/list/singly_linked_list/singly_linked_list.c
Kept this one because the destination seems more relevant.

As per issue OpenGenus#3934 there were duplicate linked list. Removed this one in cosmos/code/data_structures/src/linked_list
kept the other one which is at cosmos/code/data_structures/src/list/singly_linked_list/singly_linked_list.c 
Kept this one because the destination seems more relevant.
@arnavb
Copy link
Member

arnavb commented Mar 9, 2019

@rucha174 I feel like the better option would be to replace the other file with the contents of this file, which is more thorough than what is already present.

@rucha174
Copy link
Contributor Author

rucha174 commented Mar 9, 2019

On it.

There was a confusion, which code is supposed to be kept and which one needs to be removed? Or do these entire directories need to be moved? (I am new to Open source, sorry for too much question)

@FR4NKESTI3N
Copy link
Contributor

@rucha174 He means, replace respective files from list/singly_linked_list/ with files from linked_list/

@arnavb Should the preprocessor directives be removed from c and cpp code after replacement? Seems excessive.

@arnavb
Copy link
Member

arnavb commented Mar 16, 2019

Right, I meant to say to remove this directory.

But before you do this, replace the implementations in this other directory with anything you feel is better from the deleted directory.

Also, yeah, the preprocessor directives aren't really necessary... not sure why they're there in a .cpp file. I assume the author probably meant to simulate a header file.

@rucha174
Copy link
Contributor Author

I have created the pull request. Please review :)

@arnavb
Copy link
Member

arnavb commented Mar 18, 2019

@rucha174 While opening a new PR is fine, do note that you can commit to the current one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants