Flow control #4046
Flow control #4046
Conversation
| ``` C++ | ||
| // custom countdown using while | ||
| #include <iostream> | ||
| using namespace std; |
There was a problem hiding this comment.
Sir, exactly which all lines?
There was a problem hiding this comment.
I have made the changes. Kindly review it.
| #include <iostream> | ||
| using namespace std; | ||
|
|
||
| int main () |
There was a problem hiding this comment.
Make sure to follow our C++ style guide.
| * If….Else Statement | ||
| * switch…case statement | ||
|
|
||
| ### if-else Statement |
There was a problem hiding this comment.
You should also include else-if here as well.
There was a problem hiding this comment.
I have made the following changes. Please review it.
| cin>>i; | ||
| switch(i) | ||
| { | ||
| case ‘V’: |
There was a problem hiding this comment.
I just noticed, don't use smart quotes, use normal single and double quotes.
There was a problem hiding this comment.
Okay, sir. I have made the changes.
| ``` | ||
| ### switch statement | ||
|
|
||
| The **switch-case** statement tests the value of an expression against a list of conditions. When a match is found, the statements associated with that condition are executed. In the case of a “switch…case” statement, the conditions are constants. Each constant is a “case” (in the body of the “switch….case” statement). |
There was a problem hiding this comment.
Not the limitations of what can be compared in a switch. For example, std::string cannot be compared in a switch case as easily as one would expect.
There was a problem hiding this comment.
Done, sir. Please review it.
|
|
||
| } | ||
| return (0); | ||
| } |
There was a problem hiding this comment.
Add a newline at the end of the file.
| } | ||
|
|
||
| } | ||
| return (0); |
There was a problem hiding this comment.
Please follow the C++, not the C style guide.
Changed the code acc to C++ guidelines
Removed #include and other declarations from Readme
Fixed single/double quote marks and added else if statement
Added the string warning to switch-case
|
@shreyagupta30 I would recommend using some C++ autoformatter (For example, if you code using VS Code, it has a C++ extension that includes autoformatting) that would do most of the formatting for you, then tweak it based on the style guide. |
|
@shreyagupta30 submit your changes soon! |
| ``` | ||
| ### Sample | ||
| ```C++ | ||
| void main() |
Fixes issue:
Changes: