Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector in C++ #4071

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Vector in C++ #4071

wants to merge 24 commits into from

Conversation

shreyagupta30
Copy link
Member

Fixes issue:

Changes:

agzuniverse
agzuniverse reviewed May 14, 2019
View reviewed changes
code/languages/C++/vector/README.md
std::cout << v[j] << ‘ ‘; //20 11 12 23
std::cout << endl;
return 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the code correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@agzuniverse
Copy link
Contributor

Do mention about begin() and end() and using it for iteration through a vector. The example already shows this.

agzuniverse
agzuniverse reviewed May 16, 2019
View reviewed changes
code/languages/C++/vector/README.md Outdated
{
std::cout << v[j] << ‘ ‘; //20 11 12 23
std::cout << endl;
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format these too. Basically paste the code into some autoformatter and paste it back here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@agzuniverse
Copy link
Contributor

You are almost done with this PR, but why are there so many deleted files?
Can you remove all commits except the ones for the readme and example of vectors? The easiest way to do this is an interactive rebase. I recommend taking some time to understand how to do an interactive rebase (if you don't know already) as it is extremely useful.

@agzuniverse
Copy link
Contributor

@shreyagupta30 do try to fix the conflicts. That is the only thing preventing your PR from being merged.
Try the interactive rebase to remove commits you do not need. If you have any doubts, feel free to ask in the Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agzuniverse agzuniverse agzuniverse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyagupta30 @agzuniverse