Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shell sort in php #4141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

la2798
Copy link

@la2798 la2798 commented Oct 1, 2019

Fixes issue:

Added code for shell sort in php

Changes:

@la2798
Copy link
Author

la2798 commented Oct 2, 2019

@AdiChat please review my PR

Copy link
Member

@AdiChat AdiChat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the changes in the other two files (README.md and data.json). The main code looks good

@la2798
Copy link
Author

la2798 commented Oct 15, 2019

okay ! Will make the changes

@la2798
Copy link
Author

la2798 commented Oct 16, 2019

@AdiChat I have found out that all the changes are reflected in all of my other PRs that I have made. It is my mistake. I will sort it all out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants