fixed duplicate files #4724
Open
fixed duplicate files #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreeya13garg I think these are the duplicate files, not the ones you deleted. There are more files in the folder you deleted. |
|
Oh i thought either of the duplicate files can be removed.
…On Wed, 25 Mar 2020 at 3:23 AM, Arnav Borborah ***@***.***> wrote:
@shreeya13garg <https://github.com/shreeya13garg> I think these
<https://github.com/OpenGenus/cosmos/tree/master/code/data_structures/src/linked_list>
are the duplicate files, not the ones you deleted. There are more files in
the folder you deleted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJD4GVWMJJLBF3HHNQ3RJETT7ANCNFSM4LSNA55Q>
.
|
|
Since there are less files in the directory I picked, I would delete those. |
|
I did what you asked to do. Thanks for your help. Please look and let me
know if it's alright or not.
…On Wed, Mar 25, 2020 at 3:26 AM Arnav Borborah ***@***.***> wrote:
Since there are less files in the directory I picked, I would delete those.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJFRQ4INKNLV6KQJP73RJEUA5ANCNFSM4LSNA55Q>
.
|
|
@shreeya13garg No the wrong directory is still deleted. I wanted you to delete this folder: https://github.com/OpenGenus/cosmos/tree/master/code/data_structures/src/linked_list. |
|
Should I delete this folder?
…On Wed, 25 Mar 2020 at 6:30 PM, Arnav Borborah ***@***.***> wrote:
@shreeya13garg <https://github.com/shreeya13garg> No the wrong directory
is still deleted. I wanted you to delete this folder:
https://github.com/OpenGenus/cosmos/tree/master/code/data_structures/src/linked_list
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJFJWNLOOIFRMX5G4NTRJH57ZANCNFSM4LSNA55Q>
.
|
|
Yes, delete the folder I linked to and revert the commit where you delete the folder you have now. |
|
But haven't your merged my commit as I got a mail from you recently that
nice work and the mail mentioned that my work was merged.
…On Thu, Mar 26, 2020 at 1:34 AM Arnav Borborah ***@***.***> wrote:
Yes, delete the folder I linked to and revert the commit where you delete
the folder you have now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJEW46F7XND75N5EUUTRJJPTHANCNFSM4LSNA55Q>
.
|
|
One more thing this link-
https://github.com/OpenGenus/cosmos/tree/master/code/data_structures/src/linked_list
is
showing 404 error and is not opening. Isnt this link which is referring to
the folder I deleted previously.
I previously deleted files from
cosmos/code/data_structures/src/linked_list. Last time I deleted the
linked_list folder from src do you want me to that again?
On Thu, Mar 26, 2020 at 10:20 AM Shreeya Garg <shreeya18415@iiitd.ac.in>
wrote:
… But haven't your merged my commit as I got a mail from you recently that
nice work and the mail mentioned that my work was merged.
On Thu, Mar 26, 2020 at 1:34 AM Arnav Borborah ***@***.***>
wrote:
> Yes, delete the folder I linked to and revert the commit where you delete
> the folder you have now.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4724 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMLBWJEW46F7XND75N5EUUTRJJPTHANCNFSM4LSNA55Q>
> .
>
|
|
! @shreeya13garg Thanks for catching my mistake. I forgot I had merged yours. Well that means the mistake is already fixed. Your other PRs for this can be closed. By removing duplicate, I meant only removing one of the duplicates which you have already done. |
arnavb
added
the
stale
|
So this issue is solved na..Can i move to next issue now?
…On Thu, 26 Mar 2020 at 7:21 PM, Arnav Borborah ***@***.***> wrote:
! @shreeya13garg <https://github.com/shreeya13garg> Thanks for catching
my mistake. I forgot I had merged yours. Well that means the mistake is
already fixed. Your other PRs for this can be closed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJD6D36H7BZV5VPMVRDRJNMWFANCNFSM4LSNA55Q>
.
|
|
I want to know the path for codes of LCM code in python, Hill_cipher
algorithm, and Merging K sorted arrays.
I have attached the codes for the following. I wanted to know the path for
these codes so that I can add them.
|
|
LCM should go in mathematical algorithms (there should already be a folder and I think it's already done). Hill cipher in cryptography. Merging k sorted arrays in unclassified. |
|
Okay I will do both of it.
…On Wed, Apr 1, 2020 at 11:42 PM Arnav Borborah ***@***.***> wrote:
LCM should go in mathematical algorithms (there should already be a folder
and I think it's already done). Hill cipher in cryptography. Merging k
sorted arrays in unclassified.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLBWJDZBM6NDCIK2PU37FTRKN7Z3ANCNFSM4LSNA55Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Duplicate code for linked list
Changes:
Deleted the directory file singly_linked_list from data_structures/src/list/ path.