Binary Search

[savi966]

Fixes issue:

Changes:

[walidbarakat]

please make your code easier to read by using blank lines.

[walidbarakat]

if low is equal to high, so in this case target is not exist, the loop condition should be only (low < high)

[savi966]

If low== high means there is only one element in array. So what if that element is equals to target.

…

On Wed, Oct 27, 2021, 7:37 PM well ***@***.***> wrote: ***@***.**** requested changes on this pull request. please make your code easier to read by using blank lines. ------------------------------ In code/algorithm_applications/src/binary_search/Binary Search.cpp <#6291 (comment)>: > @@ -0,0 +1,32 @@ +#include<bits/stdc++.h> +using namespace std; +int solve(int arr[],int n,int target){ + int low=0; + int high=n-1; + while(low<=high){ if *low* is equal to *high*, so in this case target is not exist, the loop condition should be only (low < high) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6291 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AV34TA3UAPFPP5WOOYW64KTUJAITPANCNFSM5GR4F26Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[AdiChat]

This directory is for applications of specific algorithms. You may need to move the implementation of Binary Search to another directory.