Ability to share Quark added #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdiChat Kindly review it. |
|
@AdiChat Changes as per your suggestions are made.
|
richa208
force-pushed
the
share
branch
3 times, most recently
from
793f923
to
05562a5
Compare
AdiChat
reviewed
Mar 16, 2018
code/popup.html
Outdated
| <hr> | ||
| <div id="share-footer" > | ||
| <p align="center" style="padding-top: 8px; margin-bottom: 2px"><b> Share Quark </b></p> | ||
| <a class="btn btn-default" target= "_blank" onclick="openWindow(600, 900, 'http://www.facebook.com/sharer.php?u=https://chrome.google.com/webstore/detail/opengenus-offline-search/lfoloadpfjildomeafpdopahkdaoofbn');" href="#"><img id="share-buttons" src="image/Facebook.png" alt="Facebook" ></img></a> |
There was a problem hiding this comment.
We cannot use onclick in a chrome extension. For this to work, one needs to trigger the function with the element on a click event. You may do this or simply, direct it to the share URL which opens on a new tab. Also, include the sharing message.
|
Nice work 👍 I have added a comment. Kindly take a look and make appropriate changes 👍 |
|
Suggested changes have been made. |
|
Looks great 😍 Hope you are enjoying your journey 🚆 with OpenGenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
#93
Changes:
A hoverable dropdown share menu is added which contains link to share quark on various social media platforms.