Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tlg0559.tlg014.1st1K-grc1.xml #1994

Merged
merged 3 commits into from
Feb 18, 2018
Merged

Added tlg0559.tlg014.1st1K-grc1.xml #1994

merged 3 commits into from
Feb 18, 2018

Conversation

sonofmun
Copy link
Contributor

@sonofmun sonofmun commented Feb 8, 2018

Most of Hero of Alexandria Fragmenta Heroniana

Most of Hero of Alexandria Fragmenta Heroniana
@ghost
Copy link

ghost commented Feb 8, 2018

Global

Changed Status
metadata_passing +2
metadata_total +2
nodes_count +10
texts_passing +1
texts_total +1

Words

Changed Status
grc +2533

Units

Changed Status
./data/tlg0559/__cts__.xml New
./data/tlg0559/tlg014/__cts__.xml New
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml New
./data/tlg0559/__cts__.xml Passing
./data/tlg0559/tlg014/__cts__.xml Passing
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml Passing

Hook UI build recap

<head>4. Tabula Heroniana I.
<lb n="20"/> (Vide prol. § 15—20.)</head>
<p><del>Ἥρωνοϲ εἰϲαγωγαί.</del></p>
<p>1. Ἡ πρώτη γεωμετρία, καθὼϲ ἡμᾶϲ ὁ παλαιὸϲ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not make sense to add another div-level (probably sections)?

<pubPlace>Leipzig</pubPlace>
<date>1864</date>
</imprint>
</monogr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan missing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sonofmun and @planatheisa, you are also missing the Volume number here, but you have it in the file for Julius Pollux.

@sonofmun
Copy link
Contributor Author

As far as I can tell, this is not a multivolume edition, so I have removed it from the Julius Pollux file.

@ghost
Copy link

ghost commented Feb 12, 2018

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +144
texts_passing +1
texts_total +1

Words

Changed Status
grc +2533

Units

Changed Status
./data/tlg0559/tlg014/__cts__.xml New
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml New
./data/tlg0559/tlg014/__cts__.xml Passing
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml Passing

Hook UI build recap

</biblStruct>
</listBibl>
</sourceDesc>
</fileDesc>
<encodingDesc>
<p>Text encoded in accordance with the latest EpiDoc standards</p>
<refsDecl n="CTS">
<cRefPattern matchPattern="(.+).(.+)" n="chapter" replacementPattern="#xpath(/tei:TEI/tei:text/tei:body/tei:div/tei:div[@n='$1']/tei:div[@n='$2'])"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be section?

@ghost
Copy link

ghost commented Feb 13, 2018

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +144
texts_passing +1
texts_total +1

Words

Changed Status
grc +2533

Units

Changed Status
./data/tlg0559/tlg014/__cts__.xml New
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml New
./data/tlg0559/tlg014/__cts__.xml Passing
./data/tlg0559/tlg014/tlg0559.tlg014.1st1K-grc1.xml Passing

Hook UI build recap

@planatheisa planatheisa merged commit b58e6ad into master Feb 18, 2018
@planatheisa planatheisa deleted the tlg0559.tlg014 branch February 18, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants